循环执行的测试代码
|
我以为我会尝试在命令行上模拟ATM机的代码kata。我决定使用TDD驱动设计。我遇到了一个有趣的场景,并对其他人在此场景中所做的事情很好奇。
如果您查看(在底部向下)我的AtmMachine类,您会注意到我故意退出了while循环,这样我的测试就不会超时。这对我来说就像是代码的气味,我想知道其他人是否这样做。
我目前的感受在以下方面分裂:
尝试对正在进行的执行进行单元测试,从而“我做错了”
无法为其编写单元测试意味着“ while”是错误的构造
到目前为止,这是我对atm机器的单元测试:
[TestClass]
public class when_atm_starts
{
private static readonly string WELCOME_MSG = \"Welcome to Al Banco de Ruiz!\";
private AtmMachine _atm;
private Mock<IAtmInput> _inputMock;
private Mock<IAtmOutput> _outputMock;
private Mock<ILogger> _loggerMock;
private Mock<ICommandFactory> _cmdFactoryMock;
[TestInitialize]
public void BeforeEachTest()
{
_inputMock = new Mock<IAtmInput>();
_outputMock = new Mock<IAtmOutput>();
_loggerMock = new Mock<ILogger>();
_cmdFactoryMock = new Mock<ICommandFactory>();
_atm = new AtmMachine(_inputMock.Object, _outputMock.Object, _loggerMock.Object, _cmdFactoryMock.Object);
}
[TestMethod]
public void no_one_should_be_logged_in()
{
this.SetupForCancelledUser();
_atm.Start();
Assert.IsNull(_atm.CurrentUser);
}
[TestMethod]
public void should_print_welcome_to_output()
{
this.SetupForCancelledUser();
_atm.Start();
_outputMock.Verify(o => o.Write(WELCOME_MSG));
}
[TestMethod]
public void should_execute_login_command()
{
Mock<ILoginCommand> loginCmdMock = new Mock<ILoginCommand>();
_cmdFactoryMock.Setup(cf => cf.GetLoginCommand(_inputMock.Object, _outputMock.Object))
.Returns(loginCmdMock.Object);
loginCmdMock.Setup(lc => lc.LogonUser())
.Returns(AtmUser.CancelledUser);
_atm.Start();
loginCmdMock.Verify(lc => lc.LogonUser());
}
private void SetupForCancelledUser()
{
Mock<ILoginCommand> loginCmdMock = new Mock<ILoginCommand>();
_cmdFactoryMock.Setup(cf => cf.GetLoginCommand(_inputMock.Object, _outputMock.Object))
.Returns(loginCmdMock.Object);
loginCmdMock.Setup(lc => lc.LogonUser())
.Returns(AtmUser.CancelledUser);
}
}
这是对应的AtmMachine类。
public class AtmMachine
{
public static readonly string WELCOME_MSG = \"Welcome to Al Banco de Ruiz!\";
private bool _shouldContinue;
private ILogger _log;
private ICommandFactory _cmdFactory;
private IAtmInput _input;
private IAtmOutput _output;
public object CurrentUser { get; set; }
public AtmMachine(
IAtmInput input,
IAtmOutput output,
ILogger logger,
ICommandFactory cmdFactory)
{
this._input = input;
this._output = output;
this._log = logger;
this._cmdFactory = cmdFactory;
}
public void Start()
{
_shouldContinue = true;
while (_shouldContinue)
{
_output.Clear();
_output.Write(WELCOME_MSG);
AtmUser user = this.GetNextUser();
if (user == AtmUser.CancelledUser) { _shouldContinue = false; }
_shouldContinue = false;
}
}
private AtmUser GetNextUser()
{
ILoginCommand loginCmd = _cmdFactory.GetLoginCommand(_input, _output);
return loginCmd.LogonUser();
}
}
没有找到相关结果
已邀请:
2 个回复
姬第柔炒
在测试内部,您可以创建一个覆盖ѭ3的特殊测试类。
另一个选择是将条件作为可模拟的类/接口注入。这是你的选择。 其次,为简单起见,我将把该循环的胆量提取到具有更高可见性的方法中,以允许测试循环中的代码。
现在,您可以直接调用
方法并跳过所有循环。 希望有帮助! 布兰登
窃誓额