如何避免捕获变量?

| 我有一个问题
foreach(var category in categories)
{
    foreach(var word in words)
    {
        var waitCallback = new WaitCallback(state =>
        {
            DoSomething(word, category);
        });

        ThreadPool.QueueUserWorkItem(waitCallback);
    }
}
DoSomething
执行时,它会为每个捕获的变量接收最新值,而不是我想要的值。我可以想像一个解决方案,但是可以想象你们可以提出更好的解决方案
已邀请:
解决此问题的规范方法是将值复制到在循环内部声明的临时变量中。
foreach(var category in categories)
{
    var catCopy = category;
    foreach(var word in words)
    {
        var wordCopy = word;
        var waitCallback = new WaitCallback(state =>
        {
            DoSomething(wordCopy, catCopy);
        });

        ThreadPool.QueueUserWorkItem(waitCallback);
    }
}
重构为:
foreach(var category in categories) {
  foreach(var word in words) {
    DoSomethingAsync(word, category);
  }
}

...

private void DoSomethingAsync(string word, string category) {
  var waitCallback = new WaitCallback(state => DoSomething(word, category));
  ThreadPool.QueueUserWorkItem(waitCallback);
}
这是简单易懂的。它说明了开发人员的意图,而不会用额外的变量使代码混乱(就像解决该问题的默认方式一样)。
供参考,我想以下方法可以解决我的问题:
foreach(var category in categories)
{
    foreach(var word in words)
    {
        var waitCallback = new WaitCallback(state =>
        {
            var kv = (KeyValuePair<string, string>)state;
            DoSomething(kv.Key, kv.Value);
        });

        var state2 = new KeyValuePair<string, string>(word, category);
        ThreadPool.QueueUserWorkItem(waitCallback, state2);
    }
}
我会这样写整个事情,这回避了问题,并且对发生的事情绝对没有疑问:
var callbacks = words.SelectMany(w => categories.Select(c =>
    new WaitCallback(state => {
        DoSomething(w, c);
    })
));

foreach (var callback in callbacks)
    ThreadPool.QueueUserWorkItem(callback);

要回复问题请先登录注册