我该如何清理？
|
我正在使用利用Google Weather API的应用程序，现在我得到了一些真正的丑陋代码，只是用来填充3天预报，看起来像这样（记住不要笑）
groupBox3.Text = set.Forecast[1].DayOfTheWeek;
label4.Text = string.Format(\"High {0}\", set.Forecast[1].High);
label3.Text = string.Format(\"Low: {0}\", set.Forecast[1].Low);
label11.Text = string.Format(\"Condition: {0}\", set.Forecast[1].Condition);
pictureBox1.Load(set.Forecast[1].Icon);
groupBox4.Text = set.Forecast[2].DayOfTheWeek;
label14.Text = string.Format(\"High {0}\", set.Forecast[2].High);
label13.Text = string.Format(\"Low: {0}\", set.Forecast[2].Low);
label20.Text = string.Format(\"Condition: {0}\", set.Forecast[2].Condition);
pictureBox2.Load(set.Forecast[2].Icon);
groupBox5.Text = set.Forecast[3].DayOfTheWeek;
label7.Text = string.Format(\"High {0}\", set.Forecast[3].High);
label6.Text = string.Format(\"Low: {0}\", set.Forecast[3].Low);
label11.Text = string.Format(\"Condition: {0}\", set.Forecast[3].Condition);
pictureBox3.Load(set.Forecast[3].Icon);
WeatherSet set = WeatherService.Response(GoogleWeatherRequest.RequestData(new WeatherService(\"99109\")));
没有找到相关结果
已邀请:
4 个回复
篮肥炼皖
的属性，并将逻辑填充到其设置器中的字段中。这样，表单的代码将非常干净，例如好像您已经将字段放入组框一样，放置也不成问题。 另外，如果有一天您需要以另一种形式甚至在另一个应用程序中呈现此数据，则将其全部置于单独的控件中将为您提供许多代码重用选项。更不用说，如果您决定将pictureBox放置在左侧而不是右侧，则可以一次更改所有预测的外观。替秀宝
for (index in number of forecasts) { groupBox[index].Text = set.Forecast[index]....; hiLabel[index].Text = ...: lowLabel[index].Text = ...: ... }财沟项胶
foreach (var item in set.Forecast.Take(3)) { var groupBox = new GroupBox(); // it don\'t if the class is actually called GroupBox... groupBox.Text = item.DayOfTheWeek; labelHigh.Text = string.Format(\"High {0}\", item.High); labelLow.Text = string.Format(\"Low: {0}\", item.Low); labelCondition.Text = string.Format(\"Condition: {0}\", item.Condition); pictureBox.Load(item.Icon); groupBox.Controls.Add(labelHigh) ... this.Controls.Add(groupBox); }凸晴
public partial class forecastView : UserControl { public forecastView() { InitializeComponent(); } public forecastView(int x, int y, int index,WeatherSet set) { InitializeComponent(); label7.Text = string.Format(\"High:{0}\", set.Forecast[index].High); label8.Text = string.Format(\"Low: {0}\", set.Forecast[index].Low); pictureBox3.Load(string.Format(\"http://www.google.com/{0}\", set.Forecast[index].Icon)); groupBox1.Text = set.Forecast[index].DayOfTheWeek; this.Location = new System.Drawing.Point(x, y); } }private void LoadControls(WeatherSet set) { RemoveConrols(); //form2.Dispose(); form = new forecastView(12, 136, 1, set); form1 = new forecastView(155, 136, 2, set); form2 = new forecastView(12, 218, 3, set); this.Controls.Add(form); this.Controls.Add(form1); this.Controls.Add(form2); }